refactor: extract render state - #93
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scope
refactor/components@de5265356608bf051e18174151c6a6b452254710render_statemodule and oneApp::renderownerhighlighter,card_cache,streaming_cache,streaming_thinking_cache,prev_total_height, andtickCardCacheinui/chat.rsandHighlighterinhighlight.rs; movesStreamingCachefromapp.rspreserved contracts
validation
cargo fmt --all -- --checkcargo check --all-targets --all-featurescargo clippy --all-targets --all-features -- -D warningscargo build --all-targets --all-featurescargo test --all-targets --all-features— 895 passed, 0 failed, 0 ignoredgit diff --checkAppfields, 6RenderStatefields, one private module, one owner, no old flat declarations/accesses, 4 phase 11 compatibility tagsexplicitly pending
Integration, broad phase 4 acceptance, manual TUI smoke, phase 5, phase 8 final rendering architecture, and phase 11 cleanup are intentionally out of scope. The ignored roadmap checkpoint/history/checksum are unchanged.